rules: consolidate duplicate match patterns in closeCollector#18587
Merged
anacrolix merged 1 commit intoerigontech:mainfrom Jan 19, 2026
Merged
rules: consolidate duplicate match patterns in closeCollector#18587anacrolix merged 1 commit intoerigontech:mainfrom
anacrolix merged 1 commit intoerigontech:mainfrom
Conversation
anacrolix
approved these changes
Jan 19, 2026
Contributor
anacrolix
left a comment
anacrolix
left a comment
There was a problem hiding this comment.
Looks correct. Odd using Go for DSLs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
closeCollectorfunction had two separatem.Match()calls with identicalWhere()andReport()clauses, differing only by the pattern template. This duplication risks inconsistent rule updates in the future.